-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add variable surface min max area features #396
Add variable surface min max area features #396
Conversation
Codecov Report
@@ Coverage Diff @@
## main #396 +/- ##
==========================================
+ Coverage 99.00% 99.38% +0.38%
==========================================
Files 79 82 +3
Lines 4711 5041 +330
==========================================
+ Hits 4664 5010 +346
+ Misses 47 31 -16
Continue to review full report at Codecov.
|
|
Spherical now also seems to work, here is an example figure of what that looks like: (basically the same input file, but with spherical coordinates:
|
In terms of functionality and basic testing, this pull request is mostly done. Benchmarks also show that also shows that there is no significant performance loss if this feature is not used, which is great. I have a few more corner case tests and a benchmark in mind and will need to improve the coverage. Will also need to properly document all the new and changed functions. After that the code and commits will be cleaned and refactored. Documentation into the user manual will be part of #379. |
78aabf6
to
7384851
Compare
7384851
to
cb0bef0
Compare
9758d57
to
2c04dbd
Compare
This was a large amount of work, but I am happy with how this pull request turned out. The thing left is to add the same feature to the oceanic plate and mantle layer and add similar tests. I expect this pull request to be merged within the next few days if there are no further issues or comments. Additional benchmarks can only be added in a follow up pull request because main doesn't have the features yet. |
…s in the input to cartesian automatically.
… to NaturalCoordinate class.
2c04dbd
to
acab243
Compare
…ace for the mantle layer .
acab243
to
6594160
Compare
…e_surface_min_max_area_features Add changelog entries for the changes made in #396: add_variable_surface_min_max_area_features
This pull request main objective is to resolve #366. It is now also added in a backward compatible way. That means that for example
"min depth":0
andmin depth":[[0]]
are both valid and will give the same result.The pull request currently only adds this functionality for continental plates, but adding it for oceanic plates and mantle layers should be easy.
The work on this pull request raised some issues along the way which had to be, or where a lot more convenient to resolve directly. This means this is a big pull request, which I am doubting about splitting up. For now I am keeping this together and I will reorganize the commits.
Here are some pictures of what is now possible with this input file: